fix: call getMethod on template type directly (#1913)

larastan · Apr 14, 2024 · 744923c · 744923c
1 parent 3e28082
commit 744923c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Methods/HigherOrderTapProxyExtension.php b/src/Methods/HigherOrderTapProxyExtension.php
@@ -9,6 +9,7 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\MethodsClassReflectionExtension;
+use PHPStan\ShouldNotHappenException;
 
 final class HigherOrderTapProxyExtension implements MethodsClassReflectionExtension
 {
@@ -35,8 +36,10 @@ public function getMethod(
     ): MethodReflection {
         $templateType = $classReflection->getActiveTemplateTypeMap()->getType('TClass');
 
-        $reflection = $templateType->getObjectClassReflections()[0]; // @phpstan-ignore-line
+        if ($templateType === null || $templateType->getObjectClassReflections() === [] || ! $templateType->hasMethod($methodName)->yes()) {
+            throw new ShouldNotHappenException();
+        }
 
-        return $reflection->getMethod($methodName, new OutOfClassScope());
+        return $templateType->getMethod($methodName, new OutOfClassScope());
     }
 }
diff --git a/tests/Type/data/helpers.php b/tests/Type/data/helpers.php
@@ -150,6 +150,7 @@ function tapHelper()
 
     assertType('Illuminate\Support\HigherOrderTapProxy<App\User>', tap(new User()));
     assertType('App\User', tap(new User())->update(['name' => 'Taylor Otwell']));
+    assertType('Illuminate\Contracts\Validation\Validator&Illuminate\Validation\Validator', tap(validator([], []))->addReplacers());
 }
 
 function urlHelper()