Allow Builder-s in Builder::union* $query parameter

[fagai]

• Added or updated tests
• Documented user facing changes
• Updated CHANGELOG.md

related: laravel/framework#42374

The Builder::union method is supports Illuminate\Database\Eloquent\Builder, but an error occurs because there is no description.

Steps to reproduce

$first = User::where('id',8);

$users = User::where('id',2)->union($first)->get();

Error Report

Parameter #1 $query of method Illuminate\Database\Eloquent\Builder<Illuminate\Database\Eloquent\Model>::union() expects Closure|Illuminate\Database\Query\Builder, Illuminate\Database\Eloquent\Builder given.

Description

Illuminate\Database\Eloquent\Builder is not a subtype of Illuminate\Database\Query\Builder.

Illuminate\Database\Eloquent\Builder

use Illuminate\Contracts\Database\Eloquent\Builder as BuilderContract;
class Builder implements BuilderContract
{

Illuminate\Database\Query\Builder

use Illuminate\Contracts\Database\Query\Builder as BuilderContract;
class Builder implements BuilderContract
{

Changes

Added type.

Breaking changes

no

[szepeviktor]

Hello @fagai! 👋
Thank you for your contributions.
Builder is a generic class, please see
https://github.com/nunomaduro/larastan/blob/1162e3b3ca2cee6ab77b67bfdf20d598ebf50f20/stubs/QueryBuilder.stub#L139

[fagai]

@szepeviktor
Thank you!
changed parameter.

[szepeviktor]

どういたしまして！

[szepeviktor]

Just add * @template TModelClass of \Illuminate\Database\Eloquent\Model to both docblocks and we are done 🚀

[fagai]

@szepeviktor
OK, Thank you!

[canvural]

Hi,

Thank you for this! Just 2 small nitpicks.

[canvural]

Ignore the previous comments. Github's diff viewer fooled me.

Thank you!

[szepeviktor]

Github's diff viewer fooled me.

@canvural Actually those were TAB characters.
Please see be2c6b3

[canvural]

@szepeviktor Ah, thank you!