[9.x] PHPStan support for union methods

[fagai]

The union method is supports EloquentBuilder, but an error occurs because there is no description.

$first = User::where('id',8);

$users = User::where('id',2)->union($first)->get();

Parameter #1 $query of method Illuminate\Database\Eloquent\Builder<Illuminate\Database\Eloquent\Model>::union() expects Closure|Illuminate\Database\Query\Builder, Illuminate\Database\Eloquent\Builder given.

[GrahamCampbell]

This is not necessary. Including subtypes of types already in the union adds no extra information. It like having a the type Person and then having Person|Man. The types are already identical, and |Man should be removed.

[fagai]

@GrahamCampbell
Illuminate\Database\Eloquent\Builder does not inherit from Illuminate\Database\Query\Builder.
It didn't look like a subtype, but is it different?

https://github.com/laravel/framework/blob/9.x/src/Illuminate/Database/Eloquent/Builder.php#L30
https://github.com/laravel/framework/blob/9.x/src/Illuminate/Database/Query/Builder.php#L29

[nunomaduro]

This is not correct, for the reason @GrahamCampbell mentioned:

This is not necessary. Including subtypes of types already in the union adds no extra information.

[fagai]

Each class implements a different interface, so they look different.
Am I misunderstanding?

[zonuexe]

@nunomaduro
Illuminate\Database\Eloquent\Builder and Illuminate\Database\Eloquent\Builder are not subclassed to each other, so they are not what @GrahamCampbell calls Person|Man.

The code that @fagai exemplifies in the issue is valid code that actually works.

• https://phpsandbox.io/n/odd-queen-wkk4-prgxg?files=%2Froutes%2Fweb.php

Is there a reasonable reason to exclude Illuminate\Database\Eloquent\Builder from PHPDoc?

[n1215]

Illuminate\Database\Eloquent\Builder is not a subtype of Illuminate\Database\Query\Builder.

[fagai]

@GrahamCampbell @nunomaduro
Not a subtype...