Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Laravel 10 #51

Merged
merged 9 commits into from
Jan 24, 2023
Merged

Conversation

ziming
Copy link
Contributor

@ziming ziming commented Jan 18, 2023

Laravel 10 coming on Feb 7

@ksassnowski
Copy link
Collaborator

Thanks! Looks like the actions are failing, though. Can you have a look at that?

@ziming
Copy link
Contributor Author

ziming commented Jan 19, 2023

laravel 10 & testbench 8 r not officially tagged as new release yet might be why.

may have to wait till laravel 10 official release before running it again

also this package has a composer.lock file that may affect the end results.

I will look deeper later once I have access to a table

@ziming
Copy link
Contributor Author

ziming commented Jan 19, 2023

@ksassnowski

1. run-phpstan / PHPStan (pull_request)

The lock file is not up to date with the latest changes in composer.json, it is recommended that you run composer update --lock.
Script composer normalize handling the post-install-cmd event returned with error code 1

Can I try delete the composer.lock file to see if it resolve this?

2. run-tests / P8.0 - L10. - prefer-lowest - ubuntu-latest (pull_request)*

Run composer require "laravel/framework:10.*" "orchestra/testbench:" "nunomaduro/larastan:" --no-interaction --no-update
Error: Option orchestra/testbench is missing a version constraint, use e.g. orchestra/testbench:^1.0

I think it is because testbench ^8.0 is not tagged or released yet. Shall we wait until after laravel 10 is officially out then re run the actions for this PR?

3. run-tests / P8.2 - L10. - prefer-lowest - ubuntu-latest (pull_request)*

Same as 2.

@ksassnowski ksassnowski merged commit e912d36 into laravel-arcanist:main Jan 24, 2023
@ksassnowski
Copy link
Collaborator

I fixed the pipeline and pushed the commits. Thanks for the contribution!

@ziming ziming deleted the support-laravel-10 branch January 24, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants