Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] SubstituteBindings to use findOneBy() #346

Merged

Conversation

rafaelucena
Copy link
Contributor

@rafaelucena rafaelucena commented Aug 29, 2018

The function findBy() will bring back an array of results, when, for the implicit bind to work, only one entity is expected.

Changes proposed in this pull request:

  • Replace the function findBy() for the function findOneBy()

The function findBy() will bring back an array of results, when, for the implicit bind to work, only one entity is expected.
@rafaelucena rafaelucena changed the title [Fix] substituteImplicitBindings using findOneBy() instead of findBy() [Fix] SubstituteBindings to use findOneBy() Aug 29, 2018
@patrickbrouwers patrickbrouwers merged commit 49ff3a4 into laravel-doctrine:1.4 Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants