Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package for Laravel notification to Bitrix24 #109

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adiafora
Copy link

Hi! I offer a new channel for notifications in Bitrix24, a popular CRM


### I'm working on a new channel
Please create an issue for it if it does not already exist, then PR you code for review.
This package makes it easy to send notifications to bitrix24 with Laravel 5.5+ and 6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 plus please


## Installation

Run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run:

}
],
"require": {
"php": ">=7.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.3 or higher please

public function send(array $params)
{
try {
$curl = curl_init();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use guzzle here please

}

/** @test */
public function it_can_send_a_notification()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get some more tests please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants