Unifonic #113
Open
Unifonic #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atymic thanks for your support and fabulous effort in this project, please any update about this channel. |
atymic
requested changes
May 18, 2021
.gitignore
Outdated
| @@ -0,0 +1,6 @@ | |||
|
|
|||
.gitignore
Outdated
| build | ||
| composer.phar | ||
| composer.lock | ||
| .phpunit.result.cache |
|
|
||
| Take a look at our [FAQ](http://laravel-notification-channels.com/) to see our small list of rules, to provide top-notch notification channels. | ||
|
|
||
| ## Contents |
There was a problem hiding this comment.
Could you highlight the main markets for this SMS provider please?
README.md
Outdated
| ``` bash | ||
| composer require laravel-notification-channels/unifonic | ||
| ``` | ||
| This package will register itself automatically if your Laravel 5.5+, trough Package auto-discovery. |
There was a problem hiding this comment.
Can remove this since we dont support below this
README.md
Outdated
|
|
||
| In order to let your Notification know which phone numer you are targeting, add the `routeNotificationForUnifonic` method to your Notifiable model. | ||
|
|
||
| **Important note**: Unifonic requires the recipients phone number to be without `+` like this format. 21267064497 |
There was a problem hiding this comment.
Could say e164, and just strip the leading plus if it's set
https://developers.omnisend.com/guides/e164-phone-number-formatting
| return '21267064497'; | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Could we have docs on the avb. methods?
composer.json
Outdated
| "require": { | ||
| "php": ">=7.2", | ||
| "guzzlehttp/guzzle": "^6.2|^7.0", | ||
| "illuminate/notifications": "~5.8 || ~6.0 || ^7.0 || ^8.0", |
src/UnifonicClient.php
Outdated
| $response = $this->client->request('POST', static::GATEWAY_URL, [ | ||
| 'form_params' => $this->buildMessageParameters($message, $recipient), | ||
| 'headers' => [ | ||
| 'Content-Type' => 'application/x-www-form-urlencoded', |
There was a problem hiding this comment.
Don't think you need to set this (set by default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification Channel for Unifonic
Related to #112