noContent responses still get status code 200 added

[spaceemotion]

• Laravel Version: 7.21.0
• PHP Version: 7.4.3
• Blueprint Version: 1.16.0
• Platform: Linux (Ubuntu 20)

Issue:

(This might be intended behavior)

Generated controllers that return response()->noContent() seem to still get 200 as their status code added. Afaik noContent() should return 204 (the default).

The code even mentions it being excluded, but the status code seems to be set incorrectly?

blueprint/src/Models/Statements/RespondStatement.php

Line 45 in e685017

return sprintf('return response()->noContent(%s);', $this->status() === 204 ? '' : $this->status());

draft.yaml:

controllers:
  User:
    resource: api

generates:

return response()->noContent(200);

[devmsh]

As mentioned here, it must return 204 if there is no response.

Waiting for @jasonmccreary decision and I can fix this if he agreed about the change.

[jasonmccreary]

I'd want to check this as I am confused on what outputs what. In general, there is nothing wrong with a response()->noContent(200).

However, to @devmsh's comment, there may be something better depending on the context (e.g. the destroy response)

[devmsh]

Unfortunately, I did not get it.

Both 200 and 204 works, but 204 seems more standardized in the restful API world.

[jasonmccreary]

Interesting. On running the draft file above, I get an error:

  Argument 1 passed to Blueprint\Generators\Statements\ResourceGenerator::visibleColumns() must be an instance of Blueprint\Models\Model, null given, called in /Users/jason/workspace/turbo-zonda/vendor/laravel-shift/blueprint/src/Generators/Statements/ResourceGenerator.php on line 105

[devmsh]

Just test it with v1.16.0 in a fresh Laravel installation and it works fine.

Maybe because Laravel has a default user model already?

[spaceemotion]

So I looked through the unit tests and the ControllerGeneratorTest has a few drafts that have the same behavior. The culprit seems to be this default configuration for api resource controllers:

blueprint/src/Lexers/ControllerLexer.php

Lines 126 to 129 in 7c9a32e

	'api.destroy' => [
	'delete' => '[singular]',
	'respond' => 200,
	],

Changing it to 204 seems to do the trick.

[jasonmccreary]

@SpaceMotion or @devmsh, can you submit the PR to fix this. I'm still not fully understanding the issue, other than a less than desired response code.