-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate migration columns with comments #347
Generate migration columns with comments #347
Conversation
- single quote and double quote string accepted.
title: string:400 comment:"Some title for the profession" | ||
description: string:400 nullable comment:'Some description for the profession' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought something like
title: string:400 comment:"Some title for the profession" | |
description: string:400 nullable comment:'Some description for the profession' | |
title: string:400 "comment:Some title for the profession" | |
description: string:400 nullable 'comment:Some description for the profession' |
should have worked out of the box?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spaceemotion why is that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on https://blueprint.laravelshift.com/docs/model-data-types/:
When specifying an attribute or modifier value which contains a space, you must wrap the value in double quotes ("). For example, enum:Ordered,Completed,"On Hold". Blueprint will unwrap the value during parsing.
I thought this was a general thing for all attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It was. Or at least the double quotes. But in your example, you also quoted the attribute (i.e. comment
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick tweak to tighten the quotes matching...
title: string:400 comment:"Some title for the profession" | ||
description: string:400 nullable comment:'Some description for the profession' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spaceemotion why is that?
- ensure the opening and closing quotes match
closes #344