Skip to content

Commit

Permalink
Binds null logger into container
Browse files Browse the repository at this point in the history
  • Loading branch information
nunomaduro committed Dec 9, 2018
1 parent ac6f46c commit 230363d
Show file tree
Hide file tree
Showing 5 changed files with 55 additions and 21 deletions.
25 changes: 13 additions & 12 deletions composer.json
Expand Up @@ -16,26 +16,27 @@
],
"require": {
"php": "^7.1.3",
"symfony/debug": "^4.1",
"symfony/process": "^4.1",
"symfony/console": "^4.1",
"dragonmantank/cron-expression": "^2.0",
"illuminate/cache": "5.7.*",
"league/flysystem": "^1.0.8",
"illuminate/events": "5.7.*",
"illuminate/config": "5.7.*",
"symfony/var-dumper": "^4.1",
"illuminate/support": "5.7.*",
"illuminate/console": "5.7.*",
"nunomaduro/collision": "^2.0",
"illuminate/container": "5.7.*",
"illuminate/contracts": "5.7.*",
"illuminate/events": "5.7.*",
"illuminate/filesystem": "5.7.*",
"illuminate/support": "5.7.*",
"laravel-zero/foundation": "5.7.*",
"dragonmantank/cron-expression": "^2.0",
"nunomaduro/laravel-console-menu":"^2.0",
"nunomaduro/laravel-console-task": "^1.0.6",
"league/flysystem": "^1.0.8",
"nunomaduro/collision": "^2.0",
"nunomaduro/laravel-console-menu": "^2.0",
"nunomaduro/laravel-console-summary": "^1.0",
"nunomaduro/laravel-desktop-notifier": "^2.0"
"nunomaduro/laravel-console-task": "^1.0.6",
"nunomaduro/laravel-desktop-notifier": "^2.0",
"psr/log": "^1.1",
"symfony/console": "^4.1",
"symfony/debug": "^4.1",
"symfony/process": "^4.1",
"symfony/var-dumper": "^4.1"
},
"require-dev": {
"phpstan/phpstan": "^0.10",
Expand Down
2 changes: 2 additions & 0 deletions src/Bootstrap/RegisterProviders.php
Expand Up @@ -21,6 +21,7 @@
use NunoMaduro\LaravelConsoleMenu\LaravelConsoleMenuServiceProvider;
use NunoMaduro\LaravelConsoleTask\LaravelConsoleTaskServiceProvider;
use LaravelZero\Framework\Providers\Collision\CollisionServiceProvider;
use LaravelZero\Framework\Providers\NullLogger\NullLoggerServiceProvider;
use NunoMaduro\LaravelConsoleSummary\LaravelConsoleSummaryServiceProvider;
use NunoMaduro\LaravelDesktopNotifier\LaravelDesktopNotifierServiceProvider;
use Illuminate\Foundation\Bootstrap\RegisterProviders as BaseRegisterProviders;
Expand All @@ -36,6 +37,7 @@ final class RegisterProviders implements BoostrapperContract
* @var string[]
*/
protected $providers = [
NullLoggerServiceProvider::class,
CollisionServiceProvider::class,
Providers\Cache\CacheServiceProvider::class,
Providers\Filesystem\FilesystemServiceProvider::class,
Expand Down
33 changes: 33 additions & 0 deletions src/Providers/NullLogger/NullLoggerServiceProvider.php
@@ -0,0 +1,33 @@
<?php

declare(strict_types=1);

/**
* This file is part of Laravel Zero.
*
* (c) Nuno Maduro <enunomaduro@gmail.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace LaravelZero\Framework\Providers\NullLogger;

use Psr\Log\NullLogger;
use Psr\Log\LoggerInterface;
use Illuminate\Support\ServiceProvider;
use Illuminate\Contracts\Foundation\Application;

/**
* @internal
*/
final class NullLoggerServiceProvider extends ServiceProvider
{
/**
* {@inheritdoc}
*/
public function register(): void
{
$this->app->singleton(LoggerInterface::class, NullLogger::class);
}
}
9 changes: 0 additions & 9 deletions tests/GitVersionServiceProviderTest.php

This file was deleted.

7 changes: 7 additions & 0 deletions tests/KernelTest.php
Expand Up @@ -4,6 +4,8 @@

namespace Tests;

use Psr\Log\NullLogger;
use Psr\Log\LoggerInterface;
use LaravelZero\Framework\Application;
use Illuminate\Support\Facades\Artisan;
use Symfony\Component\Console\Input\ArrayInput;
Expand All @@ -22,4 +24,9 @@ public function testBindedOutputIntoContainer(): void
->get(OutputInterface::class)
);
}

public function testBindedNullLoggerIntoContainer(): void
{
$this->assertInstanceOf(NullLogger::class, app(LoggerInterface::class));
}
}

0 comments on commit 230363d

Please sign in to comment.