Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undefined quantity notice #1375

Closed
wants to merge 1 commit into from
Closed

Conversation

Lyrisbee
Copy link
Contributor

@Lyrisbee Lyrisbee commented Jun 14, 2022

Fixed Stripe Notice: Undefined property of Stripe\SubscriptionItem instance: quantity when creating or swapping to a single metered price.

Test:

cashier-stripe % ./vendor/bin/phpunit --filter test_swap_metered_price_to_different_price
PHPUnit 9.5.20

Stripe Notice: Undefined property of Stripe\SubscriptionItem instance: quantity
Stripe Notice: Undefined property of Stripe\SubscriptionItem instance: quantity
.Stripe Notice: Undefined property of Stripe\SubscriptionItem instance: quantity
Stripe Notice: Undefined property of Stripe\SubscriptionItem instance: quantity
.                                                                  2 / 2 (100%)

Time: 00:23.421, Memory: 28.00 MB

OK (2 tests, 24 assertions)

@github-actions
Copy link

Thanks for submitting a PR!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the relevant GitHub documentation. Additionally, GitHub doesn't allow maintainer permissions from organization accounts. Please resubmit this PR with maintainer permissions enabled.

@github-actions github-actions bot closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant