Add option to type in an element without clearing #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ChromeDriver gives an error when trying to type in a 'date' field.
This commit adds a `$clear` parameter to the `type()` method that allows a user to continue typing into a field (and thus work around the ChromeDriver error).
usage:
```php
$browser->type('@datefield', 01012016, false);
```
|
I'm not a big fan of boolean parameters for this kind of thing. Maybe a whole new method? |
|
@thijsvdanker there's already a method for this apparently: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ChromeDriver gives an error when trying to type in a 'date' field.
This commit adds a
$clearparameter to thetype()method that allows a user to continue typing into a field (and thus work around the ChromeDriver error).usage:
It might be that the
keys()method is exactly for this use case.In that case it might be nice to provide some documentation / exception handling or automatic fallback for the ChromeDriver.