-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log console content into files #139
Conversation
:) |
That looks really nice! I think it would be useful to have the logs accessible within your tests via a fluent API and already before $browser
->visit('/')
->doSomething()
->assertLogEmpty()
->doSomethingElseThatLogsMessages()
->assertLogContains('this is a message I expect to be in the browser log'); Javascript frameworks like Just an idea, feel free to ignore it 😆 |
could you add a .gitignore file same as the screenshot dir? Because if I just check out the Project I get an error:
|
Same thing. Need to create folder automatically?
|
@taylorotwell since this was merged, is there any possibility you could reconsider storing the HTML output as well? #118 (I could rework the PR to make the code better, etc.) |
@bbashy It's created when running We should wrap these commands in |
yeah and there is no |
When #166 is merged and tagged and you have upgraded dusk to the new version, then you can just run Until then, you should just create the |
I think dusk should create the |
@rogervila sounds even better than my PR. And it might also be good to purge old logs on each run (as we already do with screenshots) |
This PR adds the functionality of storing the browser console content into files for further inspection. Upon installation a
Browser/console
directory will be created to store the log files of each test.An example log file looks like: