Prevent triggering belongs to query if there are no relations to load #…

…42493
laravel · May 30, 2022 · c3253ab · c3253ab · Rijen · Mar 21, 2023
1 parent acddea7
commit c3253ab
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 4 deletions.
diff --git a/src/Illuminate/Database/Eloquent/Relations/BelongsTo.php b/src/Illuminate/Database/Eloquent/Relations/BelongsTo.php
@@ -15,6 +15,8 @@ class BelongsTo extends Relation
         InteractsWithDictionary,
         SupportsDefaultModels;
 
+    protected bool $hasValidConstrains = true;
+
     /**
      * The child model instance of the relation.
      *
@@ -113,7 +115,15 @@ public function addEagerConstraints(array $models)
 
         $whereIn = $this->whereInMethod($this->related, $this->ownerKey);
 
-        $this->query->{$whereIn}($key, $this->getEagerModelKeys($models));
+        // Do trigger query if there is nothing to load
+        $eagerModelKeys = $this->getEagerModelKeys($models);
+
+        if ($eagerModelKeys === []) {
+            $this->hasValidConstrains = false;
+            return;
+        }
+
+        $this->query->{$whereIn}($key, $eagerModelKeys);
     }
 
     /**
@@ -140,6 +150,15 @@ protected function getEagerModelKeys(array $models)
         return array_values(array_unique($keys));
     }
 
+    public function getEager()
+    {
+        if ($this->hasValidConstrains) {
+            return parent::getEager();
+        }
+
+        return new Collection();
+    }
+
     /**
      * Initialize the relation on a set of models.
      *

diff --git a/tests/Database/DatabaseEloquentBelongsToTest.php b/tests/Database/DatabaseEloquentBelongsToTest.php
@@ -86,6 +86,16 @@ public function testIdsInEagerConstraintsCanBeZero()
         $relation->addEagerConstraints($models);
     }
 
+    public function testIdsInEagerConstraintsWithMixedRelationExistOrNonExists()
+    {
+        $relation = $this->getRelation();
+        $relation->getRelated()->shouldReceive('getKeyName')->andReturn('id');
+        $relation->getRelated()->shouldReceive('getKeyType')->andReturn('int');
+        $relation->getQuery()->shouldReceive('whereIntegerInRaw')->once()->with('relation.id', [0, 'foreign.value']);
+        $models = [new EloquentBelongsToModelStub, new EloquentBelongsToModelStubWithZeroId, new MissingEloquentBelongsToModelStub];
+        $relation->addEagerConstraints($models);
+    }
+
     public function testRelationIsProperlyInitialized()
     {
         $relation = $this->getRelation();
@@ -175,15 +185,17 @@ public function testDefaultEagerConstraintsWhenIncrementing()
         $relation = $this->getRelation();
         $relation->getRelated()->shouldReceive('getKeyName')->andReturn('id');
         $relation->getRelated()->shouldReceive('getKeyType')->andReturn('int');
-        $relation->getQuery()->shouldReceive('whereIntegerInRaw')->once()->with('relation.id', m::mustBe([]));
+        $relation->getQuery()->shouldReceive('whereIntegerInRaw')->never();
+        $relation->getQuery()->shouldReceive('whereIn')->never();
         $models = [new MissingEloquentBelongsToModelStub, new MissingEloquentBelongsToModelStub];
         $relation->addEagerConstraints($models);
     }
 
     public function testDefaultEagerConstraintsWhenIncrementingAndNonIntKeyType()
     {
         $relation = $this->getRelation(null, 'string');
-        $relation->getQuery()->shouldReceive('whereIn')->once()->with('relation.id', m::mustBe([]));
+        $relation->getQuery()->shouldReceive('whereIntegerInRaw')->never();
+        $relation->getQuery()->shouldReceive('whereIn')->never();
         $models = [new MissingEloquentBelongsToModelStub, new MissingEloquentBelongsToModelStub];
         $relation->addEagerConstraints($models);
     }
@@ -193,7 +205,8 @@ public function testDefaultEagerConstraintsWhenNotIncrementing()
         $relation = $this->getRelation();
         $relation->getRelated()->shouldReceive('getKeyName')->andReturn('id');
         $relation->getRelated()->shouldReceive('getKeyType')->andReturn('int');
-        $relation->getQuery()->shouldReceive('whereIntegerInRaw')->once()->with('relation.id', m::mustBe([]));
+        $relation->getQuery()->shouldReceive('whereIntegerInRaw')->never();
+        $relation->getQuery()->shouldReceive('whereIn')->never();
         $models = [new MissingEloquentBelongsToModelStub, new MissingEloquentBelongsToModelStub];
         $relation->addEagerConstraints($models);
     }