-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Str::slug() not working with other characters aside english #29835
Comments
Think we need to add those characters here: https://github.com/laravel/framework/blob/5.8/src/Illuminate/Support/Str.php#L737-L763 If you could send in a PR, that'd be great. Don't speak Hebrew myself 😅 |
Also: 8.3.4 isn't a Laravel release. Did you mean a different version? |
Oh, haha i have updated the version. |
I will try it right now. |
Added this pull request: |
Description:
I am trying to use
Str::slug()
with another language than English(Hebrew in my case), but it is not working.while
$request->title
is in Hebrew, the following will not return anything:Str::slug($request->title);
But with English, it will.
I have also tried this form, but also not working:
Str::slug($request->title, '-', 'he');
Steps To Reproduce:
Just send a Hebrew sentence to
Str::slug()
;An example sentence(actually says 'this is a system test'):
Thanks for the help.
The text was updated successfully, but these errors were encountered: