Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Remove the $this->path call from the constructor #10947

Merged
merged 3 commits into from Nov 14, 2015
Merged

[5.1] Remove the $this->path call from the constructor #10947

merged 3 commits into from Nov 14, 2015

Conversation

harikt
Copy link
Contributor

@harikt harikt commented Nov 14, 2015

Fixed #10909 .

$this->path = $this->path != '/' ? rtrim($this->path, '/').'/' : $this->path;

is resetting the real path appending a / always.

@harikt
Copy link
Contributor Author

harikt commented Nov 14, 2015

The tests are green. CI fails for there is no full stop.

-     * This test is useful when integrating with illuminate/database
+     * This test is useful when integrating with illuminate/database.

@GrahamCampbell
Copy link
Member

Please remove that phpdoc alltogether.

@GrahamCampbell GrahamCampbell changed the title Remove the $this->path call from the constructor [5.1] Remove the $this->path call from the constructor Nov 14, 2015
@harikt
Copy link
Contributor Author

harikt commented Nov 14, 2015

@GrahamCampbell the reason I kept is people not changing the test with the call for

        Paginator::currentPageResolver(function ($pageName) {
+            return 2;
+        });
+        Paginator::currentPathResolver(function () {
+            return '/posts';
+        });

@GrahamCampbell
Copy link
Member

Please add a fullstop then. ;)

@taylorotwell taylorotwell merged commit bd09f81 into laravel:5.1 Nov 14, 2015
@harikt harikt deleted the patch-2 branch December 25, 2015 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants