Pluralizer Case Sensitivity #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a matchCase method to attempt to determine case format and apply it but fallback to default value if not found. Added matchCase to the irregular and inflected return values.
Add tests to support new case 'aware' plural and singular methods.
|
Not sure why the Travis 5.3 build failed. 5.4 passed ok. Says something wrong with CookieTest but don't even think the pluralizer is used in that class? My testing passed locally. |
|
5.3 build failed presumably from the same issue causing #1238? Error is at the same line. @taylorotwell |
Removed space to trigger rebuild from travis.
|
Just removing extra space to trigger a rebuild. |
|
Passed with no 'real' change in coding. |
|
Top job there @helmut. Good work. |
|
Thanks ben... as a fellow aussie I was tempted to rename it 'pluraliser' while I was at it! |
taylorotwell
added a commit
that referenced
this pull request
May 12, 2013
Pluralizer Case Sensitivity
theninja
pushed a commit
to theninja/framework
that referenced
this pull request
Feb 21, 2018
This PR changes the 'mix' helper function to take URLs coming from the hot file. This feature is fully backwards compatible. Supporting Laravel-Mix Pull Request laravel#1246, allowing Hot Module Reloading with custom hosts and ports Do not merge straight away, awaiting reply of laravel-mix/laravel-mix#1246 Let me know if you require tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that this has been discussed before but this issue keeps bugging me so I thought I would have a crack at solving it in the cleanest way I could find in the hopes of a change of heart. I have modified the pluralizer to maintain case sensitivity on irregular words and also fixes the case matching on uppercase regular words. For example...
And if you accept this pull request.
Check out the implementation and if you sitll think this is too clunky then I will let it go but I think this is not a bad fix for the current inconsistency with the function.
Also discussed here #855