[5.3] Stricter comparison when replacing URL for LocalAdapter #17097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have an edgy case with a directory name that starts with string `public`, like this: - `/storage/app/public/public.../files` So this was triggering the ternary on line `298` and the resulting URL was broken. Here is a real example: - Upload public path for LocalAdapter is `publicala/logo.svg`, full path from project root being `/storage/app/public/publicala/logo.svg`. - Generated URL was `https://laravelapp.dev/storageala/logo.svg` With this litle patch the generated URL is `https://laravelapp.dev/storage/publicala/logo.svg` This would also be useful for directory names ending with string `public`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a rare case with a directory name that starts with string
public, like this:/storage/app/public/public.../filesSo this was triggering the ternary on line
298and the resulting URL was broken.Here is a real example:
publicala/logo.svg, full path from project root being/storage/app/public/publicala/logo.svg.https://laravelapp.dev/storageala/logo.svgWith this litle patch the generated URL is
https://laravelapp.dev/storage/publicala/logo.svgThis would also be useful for directory names ending with string
public