[5.5] Refactor container

[laurencei]

With 5.5 we can refactor Container with a small contract change, which should greatly improve the maintainability of Container moving forward. We only need one make() path to handle, rather than the current situation of both makeWith() and make().

This PR includes keeping makeWith() as an alias of make() - so people already using makeWith() in their code do not need to change anything.

The only "break" is the contract for custom implementations - but even that is a simply optional parameter addition and would not require changing any current code in applications (apart from the contract implementation).

[deleugpn]

If it's only an alias, maybe deprecate it in favor of make?

[laurencei]

Although we could - I was just thinking about minimising unnecessary breaking changes for 5.5 or onwards.

For 2-3 lines of code it seems simple to keep - and I've added a framework test to ensure it works as intended (so wont be lost in future refactors).

Up to Taylor - happy to remove if needed.

[laurencei]

Oh - and some Packages already use makeWith() - so it'll create issues about dual 5.4 & 5.5 maintainability if it was removed.

[deleugpn]

Definitely do not remove it! I was thinking about annotate as @deprecated for future removal.

[unstoppablecarl]

Is there any interest in adding $parametersback in to build($concrete, $parameters = []) as well?

make / makeWith lets you do the following:

class MyImplementation implements MyContract {
    public function __construct(SomeDependency $dep, $primitiveArg){}
}

$app->bind(MyContract::class, function ($app) {
    return $app->make(MyImplementation::class, ['primitiveArg' => 99]);
});

$instance = $app->make(MyContract::class);

There is currently no way to inject primitives without a contract:
Before the removal of $parameters you could do this:

class MyImplementation {
    public function __construct(DependencyContract $dc, $primitiveArg){}
}

$app->bind(MyImplementation::class, function ($app) {
    // infinite loop among other issues 
    // return $app->make(MyImplementation::class, ['primitiveArg' => 99]);
    return $app->build(MyImplementation::class, ['primitiveArg' => 99]);
});

$instance = $app->make(MyImplementation::class);

Maybe there is a workaround I'm not aware of.

Every feature of the container seems to be designed to allow it to function by binding interfaces and binding direct implementations. I think it would be strange to leave this ability out.