New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] fix issue with chunkById() when orderByRaw() is used #20236

Merged

taylorotwell merged 1 commit into laravel:5.4 from themsaid:Builder/removeExistingOrdersFor

Jul 24, 2017

Member

themsaid commented Jul 24, 2017

When orderByRaw() is used the orders array of the builder will have a member like:

[
    "type" => "Raw"
    "sql" => "name desc"
  ]

There's no column array key, so the code changes in the PR will prevent an undefined index error when this method is used why chunking by ID.


           Ignore removal for raw order

0521c76

taylorotwell merged commit ded3279 into laravel:5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet