New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] Fake the default storage disk by default #20625

Merged

taylorotwell merged 2 commits into laravel:master from guidocella:storage-fake-default-disk

Aug 18, 2017

Contributor

guidocella commented Aug 18, 2017

No description provided.


          Fake the default storage disk

5a2d356

Member

taylorotwell commented Aug 18, 2017

Why did you use an empty string instead of null?

Contributor Author

guidocella commented Aug 18, 2017 •

edited

Loading

I searched beforehand to decide and found other functions with string arguments defaulting to an empty string, for example
https://github.com/laravel/framework/blob/5.4/src/Illuminate/Database/Connection.php#L155
https://github.com/laravel/framework/blob/5.4/src/Illuminate/Foundation/Application.php#L300
https://github.com/laravel/framework/blob/5.4/src/Illuminate/Database/Query/Builder.php#L1452

Changed it to null :)


          Default arguments to null

2c42583

taylorotwell merged commit 60bf7cc into laravel:master

guidocella deleted the storage-fake-default-disk branch

August 18, 2017 20:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment