[5.5] Fix exception handling #21086
Merged
[5.5] Fix exception handling #21086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix the bug only. Don't add new features in the same PR. |
sileence
force-pushed
the
fix_exception_handling
branch
2 times, most recently
from
4d9cce7
to
9cf665e
Compare
sileence
force-pushed
the
fix_exception_handling
branch
from
9cf665e
to
665041c
Compare
|
@taylorotwell done |
sileence
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a problem with
withoutExceptionHandling, if you call it twice or more then the previous exception handler is reassigned the anonymous class!So I changed previousExceptionHandler to originalExceptionHandler and prevented it to be assigned more than once.