Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Ignore select bindings while building update query #21173

Merged
merged 3 commits into from
Sep 13, 2017
Merged

[5.5] Ignore select bindings while building update query #21173

merged 3 commits into from
Sep 13, 2017

Conversation

themsaid
Copy link
Member

The test with this PR shows an example of a sub select query using the default withCount model property, but this basically affects every sub select query.

When building the update query, we use where and join bindings but we don't use the select bindings, so any leftovers in this select binding will be used by the final query even though the final query doesn't need it, which will cause incorrect order of bindings.

This PR fixes the following issue: #20640

@taylorotwell taylorotwell merged commit fb59a31 into laravel:5.5 Sep 13, 2017
@brunogaspar
Copy link
Contributor

Can this be ported to 5.4? The bug is very present there and was reported for 5.4 on #20640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants