tooManyAttempts method of RateLimiter class parameter fix #22197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update docs for queue:retry command At the moment its not obvious that you can pass 'all' as an id without looking through the code. * Update RetryCommand.php
* Fix connection resolver and static side effect Fixes laravel#22133 Signed-off-by: Beau Hastings <beausy@gmail.com> * Formatting
|
This should be pointing to master |
|
Those are fine in this case you are modifying the public API that's why. And btw, you need to rebase your branch |
|
What problem does this change actually fix? |
|
Has a bunch of other commits in the history. Please resubmit fresh to master. |
|
@jmarcher Thanks for clarifying the API thing. And I just changed the pointing branch in GitHub web UI form @sisve This @taylorotwell My new submission is #22202 . Please have a look when you get time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$decayMinutes = 1parameter has no usage inside the method. So we better remove it.