Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Removed unused parameter form anonymous function #22191

Conversation

khanrn
Copy link
Contributor

@khanrn khanrn commented Nov 24, 2017

Removed unused parameter form anonymous function inside aliases method of PackageManifest class.

@Dylan-DPC-zz
Copy link

You submitted the same PR twice. You can close this.

@khanrn
Copy link
Contributor Author

khanrn commented Nov 24, 2017

No @Dylan-DPC. They are for different methods. Please check the changes.

@Dylan-DPC-zz
Copy link

My bad. both could have been in one PR though 👍

@khanrn
Copy link
Contributor Author

khanrn commented Nov 24, 2017

I know it could be ! But I figured the second method later when I already named the previous branch. :(

@Dylan-DPC-zz
Copy link

Ah not an issue. You can always push more commits to the same branch

@taylorotwell taylorotwell merged commit 667bb02 into laravel:5.5 Nov 24, 2017
@khanrn khanrn deleted the PackageManifest-aliases-method-anonymous-function-parameter-fix branch November 24, 2017 16:21
@GrahamCampbell GrahamCampbell changed the title Removed unused parameter form anonymous function. [5.5] Removed unused parameter form anonymous function. Nov 24, 2017
@GrahamCampbell GrahamCampbell changed the title [5.5] Removed unused parameter form anonymous function. [5.5] Removed unused parameter form anonymous function Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants