[5.6] database queue transaction wrap#22433
Merged
Merged
Conversation
ph4r05
force-pushed
the
5.6_database_queue_tsx_wrap
branch
from
8641b84 to
4bf79be
Compare
- pop() transaction wrapped in closure for easier readability, removing side effect of marshalJob() which nonintuitively commits the transaction
ph4r05
force-pushed
the
5.6_database_queue_tsx_wrap
branch
from
4bf79be to
c38ee67
Compare
Member
|
I have a somewhat strong suspicion we are breaking things and making deadlock issues worse here but will give it a shot. 😄 |
Contributor
|
Looks great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #22394 with @sisve and @deleugpn the transaction in
DatabaseQueue::popis wrapped in the transaction closure for better readability and simplicity.This also enables to remove a side effect of
DatabaseQueue::marshalJobcommitting the transaction which is nonintuitive and confusing - potential breaking change for third-party code - the reason for adding to 5.6.