[5.2] Adds is_null check to Eloquent Builder callScope #22927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, 5.2 is closed for changes. |
|
Now i'm serving 200k users at https://a3.unipa.it/, upgrading to L>=5.3 is too dangerous at the moment. Yesterday i was forced to upgrade server to PHP7.2 and now some production functionalities are broken. Please reconsider backport. Thank you in advance. |
|
@peyobr If that is the case then fork the framework fix those issues on your 5.2 branch and your problem is solved. |
|
Actually it would be great to enjoy of an official back-port. If no other option exists, you are right: i'll fork and fix on my own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #19381 also exists on Laravel 5.2 with PHP 7.2. This brings the fix to the 5.2 branch.