Skip to content

[5.6] Fix assertSessionHasErrors - #23093

Merged
taylorotwell merged 1 commit into
laravel:5.6from
sileence:fix_assert_session_has_errors
Feb 9, 2018
Merged

taylorotwell merged 1 commit into
laravel:5.6from
sileence:fix_assert_session_has_errors

Conversation

@sileence

@sileence sileence commented Feb 9, 2018 •

Copy link
Copy Markdown
Contributor

Here the variable used with is_int should be $key no $value (same as in Laravel 5.5).

@sileence sileence changed the title Fix assertSessionHasErrors [5.6] Fix assertSessionHasErrors Feb 9, 2018
@XavRsl

XavRsl commented Feb 9, 2018

Copy link
Copy Markdown

Arg... Had my pull request ready!

@sileence

sileence commented Feb 9, 2018

Copy link
Copy Markdown
Contributor Author

@XavRsl haha, that has happened to me before, I double checked, but still knew someone else was probably going to send the same fix soon. This speaks very well about the Laravel community, I guess :)

@taylorotwell
taylorotwell merged commit 15ffac3 into laravel:5.6 Feb 9, 2018
salmanarshad321 pushed a commit to salmanarshad321/framework that referenced this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants