Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Fix assertSessionHasErrors #23093

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

sileence
Copy link
Contributor

@sileence sileence commented Feb 9, 2018

Here the variable used with is_int should be $key no $value (same as in Laravel 5.5).

@sileence sileence changed the title Fix assertSessionHasErrors [5.6] Fix assertSessionHasErrors Feb 9, 2018
@XavRsl
Copy link

XavRsl commented Feb 9, 2018

Arg... Had my pull request ready!

@sileence
Copy link
Contributor Author

sileence commented Feb 9, 2018

@XavRsl haha, that has happened to me before, I double checked, but still knew someone else was probably going to send the same fix soon. This speaks very well about the Laravel community, I guess :)

@taylorotwell taylorotwell merged commit 15ffac3 into laravel:5.6 Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants