[5.6] Fix cache for loggers#23118
Merged
Merged
Conversation
Contributor
|
Could you add some tests to show it is getting the same instance? That will help prevent regressions later. |
Contributor
Author
|
@laurencei done |
sisve
reviewed
Feb 11, 2018
| $logger1 = $manager->channel('single')->getLogger(); | ||
| $logger2 = $manager->channel('single')->getLogger(); | ||
|
|
||
| $this->assertEquals(spl_object_id($logger1), spl_object_id($logger2)); |
Contributor
There was a problem hiding this comment.
This could probably be an $this->assertSame($logger1, $logger2);
Collaborator
There was a problem hiding this comment.
Just do assertSame on the objects.
GrahamCampbell
requested changes
Feb 11, 2018
| $logger1 = $manager->channel('single')->getLogger(); | ||
| $logger2 = $manager->channel('single')->getLogger(); | ||
|
|
||
| $this->assertEquals(spl_object_id($logger1), spl_object_id($logger2)); |
Collaborator
There was a problem hiding this comment.
Just do assertSame on the objects.
Contributor
Author
|
@GrahamCampbell done. I realise I opened this PR into the wrong branch. I intended this PR for 5.6 (it's a bug fix), should I open a new PR? |
Collaborator
|
Hard reset your branch to 5.6, then cherry-pick your commits and force push. |
Contributor
Author
|
Thanks. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #23117