Skip to content

[5.6] Ability to set mail message ID right hand side using a config value#23181

Merged
taylorotwell merged 2 commits into
laravel:5.6from
themsaid:pr/30297
Feb 16, 2018
Merged

[5.6] Ability to set mail message ID right hand side using a config value#23181
taylorotwell merged 2 commits into
laravel:5.6from
themsaid:pr/30297

Conversation

@themsaid
Copy link
Copy Markdown
Member

screen shot 2018-02-15 at 9 26 21 pm

This PR adds the ability to set the right hand side of the Message-id header to a specific domain.

To do this, you need to set the mail.domain config value to a valid domain.

@sisve
Copy link
Copy Markdown
Contributor

sisve commented Feb 15, 2018

No tests?

@taylorotwell
Copy link
Copy Markdown
Member

We can probably move this into the singleton registration for the mailer, so we don't load this until it's needed?

@themsaid
Copy link
Copy Markdown
Member Author

@taylorotwell moved it into the singleton and also added a condition to only run it a config value was set.

@taylorotwell taylorotwell merged commit 5e4b2c5 into laravel:5.6 Feb 16, 2018
@tillkruss
Copy link
Copy Markdown
Contributor

@themsaid: This should probably be either mentioned in the docs, or maybe even be added to config/mail.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants