Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Update the list of removed packages when installing the "none" preset #23305

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

depsimon
Copy link
Contributor

At the moment when running php artisan preset none the bootstrap and popper.js dependencies are not removed from package.json.

The current "none" preset removes bootstrap-sass which is not a dependency anymore.

popper.js seems to be a Bootstrap dependency and is added when running php artisan preset bootstrap so keeping it is not required.

@tillkruss tillkruss changed the title This PR updates the list of removed packages when installing the "none" preset [5.6] This PR updates the list of removed packages when installing the "none" preset Feb 26, 2018
@tillkruss tillkruss changed the title [5.6] This PR updates the list of removed packages when installing the "none" preset [5.6] Update the list of removed packages when installing the "none" preset Feb 26, 2018
@taylorotwell taylorotwell merged commit 9b1c5d2 into laravel:5.6 Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants