[5.6] Only set ID on NotificationFake if there is no ID set#23470
Merged
Conversation
hotmeteor
changed the title
Contributor
|
This might be the greatest idea since your |
|
|
||
| foreach ($notifiables as $notifiable) { | ||
| $notification->id = Uuid::uuid4()->toString(); | ||
| if (! $notification->id) { |
There was a problem hiding this comment.
This might sound a bit nitpicky, but wouldn't checking for null be preferable here to allow '0' to be used as an ID?
Contributor
Author
There was a problem hiding this comment.
Well a UUID would never be 0, so not sure that makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
NotificationFake@sendNowmethod behave the same way as the sending functionality in theNotificationSender, in which the sender checks if the notification ID has already been set before setting it.