[5.7] Added test helper to assert that a Job has been queued with a Chain #23508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added callback to support identifying particular jobs - Added tests
- Separated assertPushedWithChain tests for each specific case - Removed unused stub classes
GrahamCampbell
changed the title
|
Any big reason you sent this to master branch instead of 5.6? |
|
Please send to 5.6 branch. |
|
Sure @taylorotwell. Will add this to 5.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new test helper when testing Jobs and allows to check if a Job was pushed with a specific Chain. The
expectedChaincan be an Array of Classes or Array of Objects.This PR is a continuation of #23381 and addresses @taylorotwell concerns on checking only for the first Job. This PR tries to fix that situation.
Hopefully it is ready now.
Cheers.