Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Changed '/' to DIRECTORY_SEPARATOR #23596

Merged
merged 1 commit into from
Mar 18, 2018

Conversation

TBlindaruk
Copy link
Contributor

No description provided.

@carusogabriel
Copy link
Contributor

Maybe is something we can do everywhere, as Laravel is use in different environments 🤔

@antonkomarev
Copy link
Contributor

antonkomarev commented Mar 18, 2018

@carusogabriel windows eats both of slashes as valid ones and Unix strictly uses /.
This comment is not against this commit. It's just about thing that nothing will be changed by this commit.

@TBlindaruk
Copy link
Contributor Author

TBlindaruk commented Mar 18, 2018

@a-komarev ,

I have found an issue #8913
And fix it: #8916


Also, we have o lot of PR already related to DIRECTORY_SEPARATOR
https://github.com/laravel/framework/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed+DIRECTORY_SEPARATOR


Also we have a lot of DIRECTORY_SEPARATOR constants in Foundation/Application.php.
I think will be better to have a one code style (at list in one file)

@taylorotwell taylorotwell merged commit 350ea24 into laravel:5.6 Mar 18, 2018
@TBlindaruk TBlindaruk deleted the directory_separator branch March 18, 2018 16:27
@antonkomarev
Copy link
Contributor

antonkomarev commented Mar 18, 2018

@TBlindaruk I'm totally agree that consistency is a key for a good software. Glad you've linked issues to this PR. That gives more weight to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants