[5.6] Use hash_equals for verifying url signatures#23618
Merged
taylorotwell merged 1 commit intolaravel:5.6from Mar 20, 2018
hmazter:5.6-url-signature-hash-equals
Merged
[5.6] Use hash_equals for verifying url signatures#23618taylorotwell merged 1 commit intolaravel:5.6from hmazter:5.6-url-signature-hash-equals
taylorotwell merged 1 commit intolaravel:5.6from
hmazter:5.6-url-signature-hash-equals
Conversation
|
This change broke my test Which works with Basically if asignature parameter is not provided it breaks. You should change this line to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR updates the comparison of the URL signature to use the timing attack safe hash_equals function instead of a simple
===.I don't know if this is strictly necessary for this use case. But since there exists a function for comparing hashes, I think it could/should be used.
Feel free to reject it if it is not needed.