[5.6] Default to an empty string when validating the signature hash query parameter#23721
Merged
taylorotwell merged 1 commit intolaravel:5.6from Mar 28, 2018
hmazter:5.6-signature-query-default
Merged
[5.6] Default to an empty string when validating the signature hash query parameter#23721taylorotwell merged 1 commit intolaravel:5.6from hmazter:5.6-signature-query-default
taylorotwell merged 1 commit intolaravel:5.6from
hmazter:5.6-signature-query-default
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #23618 fixing the problem explained in #23618 (comment)
When validating a signature and the signature query param is not present in the request,
hash_equalswill throw anErrorExceptionsince it expects a string to compare but$request->query('signature')will returnnull