[5.6] make model factory after method signatures more consistent#23676
Merged
taylorotwell merged 1 commit intoMar 23, 2018
Conversation
| * @return $this | ||
| */ | ||
| public function afterMaking($class, $callback) | ||
| public function afterMaking($class, callable $callback, $name = 'default') |
Collaborator
There was a problem hiding this comment.
Please remove this extra type from the definition. It's a breaking change to the signature.
| * @return $this | ||
| */ | ||
| public function afterMakingState($class, $state, $callback) | ||
| public function afterMakingState($class, $state, callable $callback) |
| * @return $this | ||
| */ | ||
| public function afterCreating($class, $callback) | ||
| public function afterCreating($class, callable $callback, $name = 'default') |
| * @return $this | ||
| */ | ||
| public function afterCreatingState($class, $state, $callback) | ||
| public function afterCreatingState($class, $state, callable $callback) |
Collaborator
There was a problem hiding this comment.
If you want to add this, please do it on master.
Contributor
Author
There was a problem hiding this comment.
I did and @taylorotwell said to put it here. #23670
Contributor
There was a problem hiding this comment.
The feature has not been tagged yet so no worries about breaking changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does some "breaking" cleanup for #23551