[5.7] make model factory after method signatures more consistent #23670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[5.7] Update suggestion constraints
…ravel#23485) * Make MessageBag constructor behaviour consistent with `add` Addresses laravel/ideas#56 and the (long-closed) laravel#13196. This change in constructor behaviour aims to bring consistency with the public `add` method on the MessageBag class, which would prevent duplicate values in any given MessageBag's key. * update test to show consistency of behaviour
…to TitasGailius-master
current Blade functionality allows the user to define a default value if the first value is not set.
`{{ $name or 'Andrew' }}`
This feature was added in an early version of Laravel to be a shorthand for
`isset($name) ? $name : 'Andrew'`
PHP7 has introduced the null coalesce operator (`??`) which performs this exact functionality.
`$name ?? 'Andrew'`
While the 'or' feature was good when it was needed, it could produce unexpected results when the characters 'or' appeared anywhere in the Blade expression. This was solved with extensive regex, but was still somewhat error prone.
Now that Laravel requires PHP 7.1, we can utilize the null coalesce operator and remove the 'or' feature. User upgrade process will be a find and replace, and the number of characters will be identical.
```
{{ $name or 'Andrew' }}
{{ $name ?? 'Andrew' }}
```
Currently, jobs scheduled via console scheduling can not specify a connection to dispatch that job onto. They can specify a queue. This PR adds an optional connection parameter to the end of the job function.
[5.7] Fixed phpdoc of the schedule class
…aravel#23619) * Update various blade array_ calls to use fully qualified Arr helper * Fix tests
* Be in line with Flysystem contract * Be in line with Flysystem
(cherry picked from commit 273b7fc)
(cherry picked from commit e856976)
…ravel_framework into TBlindaruk-disable_created_at
|
Please send to 5.6 branch. I haven't tagged this stuff yet so it's not breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some "breaking" cleanup for #23551