[5.6] Add unset() method in FilesystemManager #24057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm building a multi tenant system and I had to add this method to be able to update the disk's roots dynamically when switching tenants. For exampel, in this app we need to switch tenants when running queue jobs.
The disk config is cached, so this method needs to be called manually before making changes to the config. After the disk is used again the new config is cached automatically.
Here is an example of a system with disks for photos and videos:
```php
// First we unset the disks
app('filesystem')->unset(['photos', 'videos']);
// Apply the tenant's slug as the disk path root
Config::set('filesystems.disks.photos.root', $this->currentTenant->slug);
Config::set('filesystems.disks.videos.root', $this->currentTenant->slug);
```
fgilio
changed the title
|
Thanks for merging! |
|
How about accepting a single string as well? |
|
Nevermind, Taylor already did it in subsequent commit cbfb4fb :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building a multi tenant system and I had to add this method to be able to update the disk's root property dynamically when switching tenants. For example, in this app we switch tenants when processing data inside queued jobs.
The disk config is cached, so this method needs to be called manually before making changes to the config. After the disk is used again the new config is cached automatically.
Here is an example of an app with disks for photos and videos:
The method accepts an array of names, but if a single string is more appropriate I can change it.