Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] fix custom blade conditional ignoring 0 as argument #24394

Merged
merged 2 commits into from
May 31, 2018
Merged

[5.6] fix custom blade conditional ignoring 0 as argument #24394

merged 2 commits into from
May 31, 2018

Conversation

tjallingt
Copy link
Contributor

Fixes #24390

Improved the ternary condition so that it will also print 0 as an argument to the check method instead of pretending there were no arguments passed to the conditional.
This happens because apparently "0" == false
Added tests that compiles a custom conditional with 0 as an argument.

@taylorotwell taylorotwell merged commit 9983fd8 into laravel:5.6 May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants