[5.6] remove unnecessary foreach from is() method #24872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmwww
changed the title
fmwww
changed the title
Merged
|
added PR to revert this BC break #24885 |
taylorotwell
pushed a commit
that referenced
this pull request
Jul 19, 2018
|
oh,I didn't noticed this situation.Thanks for telling me. @browner12 |
|
no problem. definitely an easy thing to miss, since passing an array through really wasn't the intended usage. I think this is still a good idea for 5.7 with a note in the upgrade guide. Let me know if you want to send that through, otherwise I can do it as well. |
|
ok. you just do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Str::is() method is already contains foreach, request is() method no need to foreach again.