Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve $request->is() method #26046

Closed
wants to merge 2 commits into from
Closed

Improve $request->is() method #26046

wants to merge 2 commits into from

Conversation

markwalet
Copy link
Contributor

I removed the foreach loops in these two methods. This still works because the Str::is method accepts arrays. This also will work slightly faster. (Not something you will notice directly but still yay)

@markwalet markwalet changed the title Improve request is method Improve $request->is() method Oct 10, 2018
@Miguel-Serejo
Copy link

This has been PRed before #24872
And then reverted due to being a breaking change: #24885

@tillkruss tillkruss closed this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markwalet @Miguel-Serejo @tillkruss