Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Adjustments in PHPDoc of chunkById() methods #25053

Merged
merged 1 commit into from
Aug 1, 2018
Merged

[5.6] Adjustments in PHPDoc of chunkById() methods #25053

merged 1 commit into from
Aug 1, 2018

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Aug 1, 2018

Some follow-up to #14711 and #17034.

  • $column can be omitted in Eloquent's method. (in Query Builder too, but it's slightly different, it's a default string)
  • $alias can be (and is most of the time) omitted.

@GrahamCampbell GrahamCampbell merged commit d638846 into laravel:5.6 Aug 1, 2018
@GrahamCampbell
Copy link
Member

Perfect, thanks. :)

@vlakoff vlakoff deleted the phpdoc branch August 1, 2018 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants