Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Fix mailables always being queued for later if using Queueable trait #25378

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

jwensley2
Copy link
Contributor

Currently if a Mailable uses the \Illuminate\Bus\Queueable trait, which is the default when using make:mail, it will always end up calling \Illuminate\Mail\Mailable::later because it is only checking if the delay property exists and not whether it is actually set.

This is a problem when using a 3rd part queue driver like https://github.com/shiftonelabs/laravel-sqs-fifo-queue which doesn't allow things to be queued for later since sqs fifo queues do not support it.

This fixes that problem by checking whether delay is actually set.

@taylorotwell taylorotwell merged commit 4eab953 into laravel:5.6 Aug 29, 2018
@GrahamCampbell GrahamCampbell changed the title Fix mailables always being queued for later if using Queueable trait [5.6] Fix mailables always being queued for later if using Queueable trait Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants