Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Remove trailing newline from hot url #25699

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Conversation

Quezler
Copy link
Contributor

@Quezler Quezler commented Sep 19, 2018

The hot file created in the public directory by mix ends with a newline.

Which is then passed on to the html, which does not look like that was intended:

screen shot 2018-09-19 at 10 23 44

▲ current | patch ▼

screen shot 2018-09-19 at 10 23 26

@ankurk91
Copy link
Contributor

ankurk91 commented Sep 19, 2018

I was about to report this.
Thanks for fixing.

For those who dont know why this is happening -
mix() helper retrieve url from public/hot file, and hot file contents look like

http://localhost:8080/

Notice the new line at end.

@taylorotwell taylorotwell merged commit 23f259a into laravel:5.7 Sep 19, 2018
@GrahamCampbell GrahamCampbell changed the title Remove trailing newline from hot url [5.7] Remove trailing newline from hot url Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants