Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Simplify condition #26121

Merged
merged 1 commit into from
Oct 15, 2018
Merged

[5.7] Simplify condition #26121

merged 1 commit into from
Oct 15, 2018

Conversation

carusogabriel
Copy link
Contributor

This PR only simplify a condition, replacing a ! + === to a simple !==

@carusogabriel carusogabriel deleted the simplify-condition branch October 14, 2018 20:09
@carusogabriel carusogabriel restored the simplify-condition branch October 14, 2018 20:10
@carusogabriel carusogabriel reopened this Oct 14, 2018
@GrahamCampbell GrahamCampbell merged commit bc84fb6 into laravel:5.7 Oct 15, 2018
@GrahamCampbell
Copy link
Member

Thanks. This seems to improve the readability, since one has to take a second to confirm the operator binding presidency of the bang, before this change. :)

@carusogabriel carusogabriel deleted the simplify-condition branch October 15, 2018 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carusogabriel @GrahamCampbell