[5.8] Upgrade to dotenv v3

[GrahamCampbell]

What's new in dotenv v3 that will affect Laravel? The safeLoad method was added in v2.5.0 (#242), and first-class support for multiline variables has landed in v3.0.0, so that SSH keys and the like can be pasted as is, without adding pseudo-newline characters (#301).

Finally, a consequence of the improvements in (#300) mean that the new way to construct a Dotenv object is via it's static create method.

[ankurk91]

Is it possible to add support for required variables in laravel.

https://github.com/vlucas/phpdotenv#requiring-variables-to-be-set

[GrahamCampbell]

Yes, you can define your own boostrapper, instead of using the default, then you're free to do whatever. :)

[GrahamCampbell]

Basically, just replace

framework/src/Illuminate/Foundation/Http/Kernel.php

Line 37 in 4866ff1

\Illuminate\Foundation\Bootstrap\LoadEnvironmentVariables::class,

with your custom class, and then you can do whatever you like with validation in there. :)

[GrahamCampbell]

@ankurk91 Thinking more about this, actually a custom boostrapper in the current framework is actually a bit of a pain. While it's nice and easy to replace it in your app (in the two kernels), it's actually also hard coded within the application's afterLoadingEnvironment method, which is used all over the testing helpers of the framework, which is unfortunate.

I'm gonna have a think about how we can make this nice to use.

[ankurk91]

@GrahamCampbell

Thanks for looking into it.

May be if we can add something like this our .env

APP_NAME=Laravel

REQUIRED_VARS=DB_HOST,DB_PORT,DB_PASSWORD

Then framework can use this array like

$dotenv =  Dotenv::create(/* ... */)

$requiredVars = explode(",", env('REQUIRED_VARS'))
$dotenv->required($requiredVars)->notEmpty();

[GrahamCampbell]

May be if we can add something like this our .env

I think I'd prefer the user defined implementation still.

I'm gonna have a think about how we can make this nice to use.

I've been looking into this some more, and this bootstrapping callback is not used anywhere actually, by the framework core, so as long as you don't use it in your code, it should be fine. If you'd want to use that method to register a callback, it can be done, but call afterBootstrapping instead, proving the name of your bootstrapper to param 1.