Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Make the redis queue blocking pop atomic (alternative PR) #27336

Merged
merged 8 commits into from
Feb 12, 2019
Merged

[5.8] Make the redis queue blocking pop atomic (alternative PR) #27336

merged 8 commits into from
Feb 12, 2019

Commits on Jan 18, 2019

  1. Make the redis queue blocking pop atomic 

    Use a separate list `queues:{{name}}:notify` to allow us to use the
BLPOP command without risking lost jobs.
    Matt Allan committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    392ef23 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2019

  1. Notify when migrating expired jobs

    Matt Allan committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    8ec3498 View commit details
    Browse the repository at this point in the history

  2. Use a Lua script for RedisQueue::push

    Matt Allan committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    0a0442b View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Add comments to the Lua scripts

    Matt Allan committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    f2cba5f View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2019

  1. always push notify; try pop(notify) with pop(job); blpop(notify) iff … 

    …no job and blocking mod enabled
    @halaei
    halaei committed Jan 27, 2019
    5 Configuration menu
    Copy the full SHA
    44860e5 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. always notify when migrating expired jobs

    @halaei
    halaei committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    fcec80a View commit details
    Browse the repository at this point in the history

  2. retry once if blpop was successful

    @halaei
    halaei committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    67883ff View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. test blocking pop

    @halaei
    halaei committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    0acaf33 View commit details
    Browse the repository at this point in the history