[5.8] Fix mix exception handling #27569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that these tests were uncommented so I did some investigating into why. It turns out that two prs referenced below were merged on either the 5.7 and 5.8 branches. I believe that due to a merge gone wrong some of the functionality from the PR sent to 5.7 was removed again causing the tests to fail (which is why they were commented out). I've re-added the changes and re-enable the commented out tests which now pass again. 5.7 PR: #26431 5.8 PR: #26289
|
@timacdonald can you maybe give this a quick look to see if everything is still implemented as you intended? From my point of view it looks good. |
|
Hey! Yea it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that these tests were uncommented so I did some investigating into why. It turns out that two prs referenced below were merged on either the 5.7 and 5.8 branches. I believe that due to a merge gone wrong some of the functionality from the PR sent to 5.7 was removed again causing the tests to fail (which is why they were commented out). I've re-added the changes and re-enable the commented out tests which now pass again.
5.7 PR: #26431
5.8 PR: #26289