[5.8] Fix fake dispatcher issue #28131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
imanghafoori1
force-pushed
the
fix_fake_dispatcher_issue
branch
2 times, most recently
from
f013232
to
343234b
Compare
|
Doesn't describe what bug is actually being fixed. |
|
@taylorotwell |
TBlindaruk
added a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Apr 16, 2019
Description: Integration tests proof that it will work with both built-in session guard or any other custom guard whether it has a dispatcher or not. Note : some build-in guards like Token guard does dispatch any events, hence there is no `setDispatcher ` method or any dispatcher on it. So there are 2 types of guards. which I think a contract (interface) is missing here, in order to mark the SessionGuard class or any other custom guard as an event dispatching guard, and enforce `setDispatcher` and `getDispatcher` methods on them.) So the clunky `method_exists` check won't be needed. Re-submit: laravel#28131 fixed: laravel#27451
TBlindaruk
added a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Apr 16, 2019
Description: Integration tests proof that it will work with both built-in session guard or any other custom guard whether it has a dispatcher or not. Note : some build-in guards like Token guard does dispatch any events, hence there is no `setDispatcher ` method or any dispatcher on it. So there are 2 types of guards. which I think a contract (interface) is missing here, in order to mark the SessionGuard class or any other custom guard as an event dispatching guard, and enforce `setDispatcher` and `getDispatcher` methods on them.) So the clunky `method_exists` check won't be needed. Re-submit: laravel#28131 fixed: laravel#27451
taylorotwell
pushed a commit
to illuminate/auth
that referenced
this pull request
Apr 17, 2019
Description: Integration tests proof that it will work with both built-in session guard or any other custom guard whether it has a dispatcher or not. Note : some build-in guards like Token guard does dispatch any events, hence there is no `setDispatcher ` method or any dispatcher on it. So there are 2 types of guards. which I think a contract (interface) is missing here, in order to mark the SessionGuard class or any other custom guard as an event dispatching guard, and enforce `setDispatcher` and `getDispatcher` methods on them.) So the clunky `method_exists` check won't be needed. Re-submit: laravel/framework#28131 fixed: laravel/framework#27451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests proof that it will work with both built-in session guard or any other custom guard whether it has a dispatcher or not.
Note : some build-in guards like Token guard does dispatch any events, hence there is no
setDispatchermethod or any dispatcher on it.So there are 2 types of guards.
which I think a contract (interface) is missing here, in order to mark the SessionGuard class or any other custom guard as an event dispatching guard, and enforce
setDispatcherandgetDispatchermethods on them.)So the clunky
method_existscheck won't be needed.